On Wed, Jan 31, 2024 at 09:59:43AM +0300, Dan Carpenter wrote: > 169 dev_err(ua->dev, "Firmware bug: Additional ACK required after ACKing a connector change.\n"); > 170 dev_err(ua->dev, "Firmware bug: Enabling workaround\n"); > 171 } > 172 > 173 if (!ua->dell_quirk_active) > --> 174 return ret; > > So this is basically an else statement and ret is zero. Smatch thinks > it should be an error code but I think it's intentional. Why reverse > the if statement, return a literal, and pull the code in a tab. I left out the not and the question mark... Why NOT reverse the if statement? regards, dan carpenter
