On Wed, Jan 17, 2024 at 11:03:20PM +0000, Rob Winn wrote:
> Add vid/pid combination for Integrel Solutions OEG Controller to cp210x driver
Please wrap the commit message at 72 columns.
> Signed-off-by: Robert Winn <rob.winn@xxxxxxxxxxxxxxxxxxxxx>
Nit: You From line should ideally match you SoB (e.g. use Robert in
both).
> ---
> drivers/usb/serial/cp210x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index 1e61fe043..d1f993eea 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -163,6 +163,7 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x10C4, 0x8A5B) }, /* CEL EM3588 ZigBee USB Stick */
> { USB_DEVICE(0x10C4, 0x8A5E) }, /* CEL EM3588 ZigBee USB Stick Long Range */
> { USB_DEVICE(0x10C4, 0x8B34) }, /* Qivicon ZigBee USB Radio Stick */
> + { USB_DEVICE(0x10C4, 0x8DDC) }, /* Integrel Solutions Integrel OEG Controller */
Stray second "Integrel"?
> { USB_DEVICE(0x10C4, 0xEA60) }, /* Silicon Labs factory default */
> { USB_DEVICE(0x10C4, 0xEA61) }, /* Silicon Labs factory default */
> { USB_DEVICE(0x10C4, 0xEA63) }, /* Silicon Labs Windows Update (CP2101-4/CP2102N) */
>
And the patch appears to be whitespace damaged (tabs replaced with
spaces).
Make sure you can send the patch to yourself (and apply it successfully)
before resending.
Johan
