On 30.01.24 13:34, Krzysztof Kozlowski wrote: > On 30/01/2024 13:26, Javier Carrasco wrote: >> The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit >> multicore controller for voice processing. >> >> Add new bindings to define the device properties. >> >> [1] https://www.xmos.com/xvf3500/ >> >> Signed-off-by: Javier Carrasco <javier.carrasco@xxxxxxxxxxxxxx> >> --- > > This should be v2. Also, please provide changelog either here or in > cover letter. > That would also have saved me from giving a reference to a previous discussion. In that case I will use v3 for the next version and the previous series for the sound subsystem will be mentioned in the changelog as v1. >> .../devicetree/bindings/sound/xmos,xvf3500.yaml | 51 ++++++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/xmos,xvf3500.yaml b/Documentation/devicetree/bindings/sound/xmos,xvf3500.yaml >> new file mode 100644 >> index 000000000000..d7d5bda23b1b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/xmos,xvf3500.yaml >> @@ -0,0 +1,51 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/xmos,xvf3500.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: XMOS XVF3500 VocalFusion Voice Processor >> + >> +maintainers: >> + - Javier Carrasco <javier.carrasco@xxxxxxxxxxxxxx> >> + >> +description: >> + The XMOS XVF3500 VocalFusion Voice Processor is a low-latency, 32-bit >> + multicore controller for voice processing. >> + https://www.xmos.com/xvf3500/ >> + >> +properties: >> + compatible: >> + const: usb20b1,0013 >> + >> + reset-gpios: >> + maxItems: 1 >> + >> + vdd-supply: >> + description: >> + Regulator for the 1V0 supply. >> + >> + vdd2-supply: >> + description: >> + Regulator for the 3V3 supply. >> + >> +required: >> + - compatible >> + - reset-gpios >> + - vdd-supply >> + - vdd2-supply >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/gpio/gpio.h> >> + >> + xvf3500 { > > Node names should be generic. See also an explanation and list of > examples (not exhaustive) in DT specification: > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > Previous version had different code here, so I don't understand why this > became model number. > Thanks for the reference, I will change it to the previous "voice-processor" > Best regards, > Krzysztof > Best regards, Javier Carrasco
