On Mon, Jan 29, 2024 at 06:58:50AM -0800, Greg Kroah-Hartman wrote: > On Mon, Jan 29, 2024 at 08:41:50AM +0100, Andreas Larsson wrote: > > On 2024-01-28 01:31, Greg Kroah-Hartman wrote: > > > On Mon, Jan 22, 2024 at 09:22:25AM +0100, Andreas Larsson wrote: > > >> This fixes relying upon linux/of_platform.h to include > > >> linux/platform_device.h, which it no longer does, thereby fixing > > >> compilation problems like: > > >> > > >> In file included from drivers/usb/host/uhci-hcd.c:850: > > >> drivers/usb/host/uhci-grlib.c: In function 'uhci_hcd_grlib_probe': > > >> drivers/usb/host/uhci-grlib.c:92:29: error: invalid use of undefined type 'struct platform_device' > > >> 92 | struct device_node *dn = op->dev.of_node; > > >> | ^~ > > >> > > >> Fixes: 0d18bcdebb2f ("of: Stop circularly including of_device.h and of_platform.h") > > > > > > I don't see this commit id in Linus's tree, where is it? > > > > Ah, sorry, it went into Linus's tree with a different commit ID. I > > should have referred to ef175b29a242. > > Please fix up and resend. Ah you did, just hadn't read all of my email yet, sorry for the noise...