On Wed, Jan 17, 2024 at 04:37:55PM -0800, Vicki Pfau wrote: > Since multiple different gadget types use similar ranges of ioctl IDs, > put all of them in the same file to avoid accidentally creating > overlaps. > > Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Vicki Pfau <vi@xxxxxxxxxxx> > --- > include/uapi/linux/usb/g_printer.h | 23 ++---------------- > include/uapi/linux/usb/g_uvc.h | 4 +-- > include/uapi/linux/usb/gadget-ioctl.h | 35 +++++++++++++++++++++++++++ > include/uapi/linux/usb/gadgetfs.h | 27 +-------------------- > 4 files changed, 39 insertions(+), 50 deletions(-) > create mode 100644 include/uapi/linux/usb/gadget-ioctl.h > > diff --git a/include/uapi/linux/usb/g_printer.h b/include/uapi/linux/usb/g_printer.h > index 7fc20e4b82f5..fc411ee3f5cc 100644 > --- a/include/uapi/linux/usb/g_printer.h > +++ b/include/uapi/linux/usb/g_printer.h > @@ -3,34 +3,15 @@ > * g_printer.h -- Header file for USB Printer gadget driver > * > * Copyright (C) 2007 Craig W. Nadler > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License as published by > - * the Free Software Foundation; either version 2 of the License, or > - * (at your option) any later version. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - * GNU General Public License for more details. > - * > - * You should have received a copy of the GNU General Public License > - * along with this program; if not, write to the Free Software > - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > */ Note, this "boiler-plate" text should be removed, you are right, but not in this commit, as it has nothing to do with it, and should be a stand-alone change. So can you please split this out? Otherwise, nice work, greg k-h
