On Wed, Jan 24, 2024 at 04:44:53PM -0800, Abhishek Pandit-Subedi wrote: > diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h > index bec920fa6b8a..94b373378f63 100644 > --- a/drivers/usb/typec/ucsi/ucsi.h > +++ b/drivers/usb/typec/ucsi/ucsi.h > @@ -3,6 +3,7 @@ > #ifndef __DRIVER_USB_TYPEC_UCSI_H > #define __DRIVER_USB_TYPEC_UCSI_H > > +#include <asm-generic/unaligned.h> Do you really need to include a asm/ include file? This feels very wrong. It's also in the wrong place, AND why "asm-generic"? That also feels wrong. thanks, greg k-h
