Re: [PATCH v2 09/15] usb: typec: qcom-pmic-typec: add support for PMI632 PMIC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 25, 2024 at 02:07:59AM +0200, Dmitry Baryshkov wrote:
> On Tue, 16 Jan 2024 at 16:23, Heikki Krogerus
> <heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Jan 16, 2024 at 02:56:11PM +0200, Dmitry Baryshkov wrote:
> > > On Tue, 16 Jan 2024 at 14:32, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
> > > > On 1/13/24 21:55, Dmitry Baryshkov wrote:
> > > > > The PMI632 PMIC support Type-C port handling, but lacks USB
> > > > > PowerDelivery support. The TCPM requires all callbacks to be provided
> > > > > by the implementation. Implement a special, 'stub' Qcom PD PHY
> > > > > implementation to enable the PMI632 support.
> > > > >
> > > > > Acked-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > > > > ---
> > > >
> > > > Still not a fan of stubby stubs :/
> > >
> > > Me too. If there are better suggestions, I'll be pleased to implement
> > > them. Greg, Heikki?
> >
> > Guenter, do you have time to look at this?
> 
> Heikki, Guenter, just a gracious ping for your opinion.
> Probably another option is to read pd_supported (or all caps) before
> checking the callbacks and then instrument all calls to PD with
> pd_supported checks.

I don't have anything to suggest here, but Guenter should really
comment this one. In any case, FWIW:

Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

-- 
heikki




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux