On Wed, Jan 24, 2024 at 03:51:58PM +0200, Heikki Krogerus wrote: > On Wed, Jan 24, 2024 at 12:12:26AM -0800, Prashant Malani wrote: > > Hi Abhishek, > > > > On Tue, Jan 23, 2024 at 2:30 PM Abhishek Pandit-Subedi > > <abhishekpandit@xxxxxxxxxx> wrote: > > > > > > From: Abhishek Pandit-Subedi <abhishekpandit@xxxxxxxxxxxx> > > > > > > Between UCSI 1.2 and UCSI 2.0, the size of the MESSAGE_IN region was > > > increased from 16 to 256. In order to avoid overflowing reads for older > > > systems, add a mechanism to use the read UCSI version to truncate read > > > sizes on UCSI v1.2. > > > > > > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@xxxxxxxxxxxx> > > I have one nit (mentioned in side-band but reproducing here for consistency), > > but will defer to the maintainer on that. > > > > The above notwithstanding, FWIW: > > Reviewed-by: Prashant Malani<pmalani@xxxxxxxxxxxx> > > > > > @@ -1556,6 +1569,15 @@ int ucsi_register(struct ucsi *ucsi) > > > if (!ucsi->version) > > > return -ENODEV; > > > > > > + /* > > > + * Version format is JJ.M.N (JJ = Major version, M = Minor version, > > > + * N = sub-minor version). > > > + */ > > > + dev_info(ucsi->dev, "Registered UCSI interface with version %x.%x.%x", > > > + UCSI_BCD_GET_MAJOR(ucsi->version), > > > + UCSI_BCD_GET_MINOR(ucsi->version), > > > + UCSI_BCD_GET_SUBMINOR(ucsi->version)); > > > > nit: I think this doesn't need to be dev_info() and can be just > > dev_dbg(), but will > > defer to the maintainer. > > I think that's okay. > > Reviewewd-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> No, when drivers are working properly they are quiet, this needs to be dev_dbg(). thanks, greg k-h
