On 12/7/23 7:16 PM, Sergey Shtylyov wrote: [...] >>> In init_freecom(), the results of usb_stor_control_msg() calls are stored >>> in the local variable and then printed out by usb_stor_dbg() (if enabled), >>> except for the 1st call, the result of which is completely ignored. Drop >>> the useless assignment. >> >> Instead, you should check the return value and handle it properly, don't >> just drop the checking entirely, that's not good. > > Hmm... I wonder if you'd actually read the patch... > I'm not dropping any checking because there's none, even at the further > call sites of usb_stor_control_msg() -- the most init_freecom() currently > is doing is printing out the result of the calls... Alan, haven't heard your opinion on this patch... What do you think? [...] MBR, Sergey
