Re: [PATCH] thunderbolt: Remove usage of the deprecated ida_simple_xx() API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 22/01/2024 à 12:29, Mika Westerberg a écrit :
On Thu, Jan 11, 2024 at 10:10:21PM +0100, Christophe JAILLET wrote:
ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

Note that the upper limit of ida_simple_get() is exclusive, but the one of
ida_alloc_range()/ida_alloc_max() is inclusive. So a -1 has been added
when needed.

Looks tood to me but wanted to check if you tested this on a real
hardware or you just build tested?



Hi,

It was compile tested only.

Transformation has been done with the help of the cocci script below.

CJ


===

@@
expression i, gfp;
@@
-    ida_simple_get(i, 0, 0, gfp)
+    ida_alloc(i, gfp)


@@
expression e1, e2, gfp;
@@
-    ida_simple_get(e1, e2, 0, gfp)
+    ida_alloc_min(e1, e2, gfp)


@@
expression e1, e2, gfp;
@@
-    ida_simple_get(e1, 0, e2, gfp)
+    ida_alloc_max(e1, e2 - 1, gfp)


@@
expression e1, e2, gfp;
@@
-    ida_simple_get(e1, e2, e2+1, gfp)
+    ida_alloc_range(e1, e2, e2, gfp)


@@
expression e1, e2, e3, gfp;
@@
-    ida_simple_get(e1, e2, e3, gfp)
+    ida_alloc_range(e1, e2, e3 - 1, gfp)


@@
expression e1, e2;
@@
-    ida_simple_remove(e1, e2)
+    ida_free(e1, e2)






[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux