Hi Christian, kernel test robot noticed the following build warnings: [auto build test WARNING on usb/usb-testing] [also build test WARNING on usb/usb-next usb/usb-linus westeri-thunderbolt/next linus/master v6.7 next-20240117] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Christian-A-Ehrhardt/usb-ucsi-Add-missing-ppm_lock/20240117-064726 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing patch link: https://lore.kernel.org/r/20240116224041.220740-4-lk%40c--e.de patch subject: [PATCH 3/3] usb: ucsi_acpi: Quirk to ack a connector change ack cmd config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240118/202401180751.BuI4xr2p-lkp@xxxxxxxxx/config) compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240118/202401180751.BuI4xr2p-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202401180751.BuI4xr2p-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/usb/typec/ucsi/ucsi_acpi.c:132: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Some Dell laptops expect that an ACK command with the vim +132 drivers/usb/typec/ucsi/ucsi_acpi.c 130 131 /** > 132 * Some Dell laptops expect that an ACK command with the 133 * UCSI_ACK_CONNECTOR_CHANGE bit set is followed by a (separate) 134 * ACK command that only has the UCSI_ACK_COMMAND_COMPLETE bit set. 135 * If this is not done events are not delivered to OSPM and 136 * subsequent commands will timeout. 137 */ 138 static int 139 ucsi_dell_sync_write(struct ucsi *ucsi, unsigned int offset, 140 const void *val, size_t val_len) 141 { 142 struct ucsi_acpi *ua = ucsi_get_drvdata(ucsi); 143 u64 cmd = *(u64*)val, ack = 0; 144 int ret; 145 146 if (UCSI_COMMAND(cmd) == UCSI_ACK_CC_CI && 147 cmd & UCSI_ACK_CONNECTOR_CHANGE) 148 ack = UCSI_ACK_CC_CI | UCSI_ACK_COMMAND_COMPLETE; 149 150 ret = ucsi_acpi_sync_write(ucsi, offset, val, val_len); 151 if (ret != 0) 152 return ret; 153 if (ack == 0) 154 return ret; 155 156 if (!ua->dell_quirk_probed) { 157 ua->dell_quirk_probed = true; 158 159 cmd = UCSI_GET_CAPABILITY; 160 ret = ucsi_acpi_sync_write(ucsi, UCSI_CONTROL, &cmd, 161 sizeof(cmd)); 162 if (ret == 0) 163 return ucsi_acpi_sync_write(ucsi, UCSI_CONTROL, 164 &ack, sizeof(ack)); 165 if (ret != -ETIMEDOUT) 166 return ret; 167 168 ua->dell_quirk_active = true; 169 } 170 171 if (!ua->dell_quirk_active) 172 return ret; 173 174 return ucsi_acpi_sync_write(ucsi, UCSI_CONTROL, &ack, sizeof(ack)); 175 } 176 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
