On Wed, Jan 17, 2024 at 02:17:40PM +0200, Dmitry Baryshkov wrote: > On Wed, 17 Jan 2024 at 10:03, Johan Hovold <johan@xxxxxxxxxx> wrote: > > > > On Tue, Jan 16, 2024 at 02:39:10PM -0500, Sasha Levin wrote: > > > From: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > > > > [ Upstream commit 1d103d6af241dbfc7e11eb9a46dff65db257a37f ] > > > > > > On sevral Qualcomm platforms (SC8180X, SM8350, SC8280XP) a call to > > > UCSI_GET_PDOS for non-PD partners will cause a firmware crash with no > > > easy way to recover from it. Since we have no easy way to determine > > > whether the partner really has PD support, shortcut UCSI_GET_PDOS on > > > such platforms. This allows us to enable UCSI support on such devices. > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > > Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > > > Link: https://lore.kernel.org/r/20231025115620.905538-2-dmitry.baryshkov@xxxxxxxxxx > > > Signed-off-by: Bjorn Andersson <andersson@xxxxxxxxxx> > > > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > > > > Correct me if I'm wrong Dmitry, but while the commit message makes this > > sound like a fix, it is not needed unless you backport follow-on patches > > that enable UCSI on these platforms. > > > > So this one can be dropped from all stable queues (unless you're > > backporting patches that enable new features and that depend on this > > one). > > Exactly. It didn't have the Fixes: tag. So I'm completely unsure why > it ended up in the autosel queue at all. Based on the text in the subject and in the changelog, it sure looks like a bugfix to me! Perhaps don't write changelogs that say "fix SOMETHING on SOMETHING" next time if they really are not a fix :) thanks, greg k-h
