Re: [RFC PATCH] usb: dwc3: gadget: Fix NULL pointer dereference in dwc3_gadget_suspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 1/17/2024 2:52 PM, UTTKARSH AGGARWAL wrote:

On 1/17/2024 12:47 PM, Kuen-Han Tsai wrote:
         ret = dwc3_gadget_soft_disconnect(dwc);
         if (ret)
                 goto err;
For improved readability, we can remove the goto statement and move
the error handling logic here.

Hi Kuen-Han,

Thanks for the suggestion.
Does this looks good to you ?

   int ret = dwc3_gadget_soft_disconnect(dwc);if (ret) {        if (dwc->softconnect)            dwc3_gadget_soft_connect(dwc);

       return ret;    }    spin_lock_irqsave(&dwc->lock, flags);    if (dwc->gadget_driver)  dwc3_disconnect_gadget(dwc);  spin_unlock_irqrestore(&dwc->lock, flags);

Sorry for the mistake.

int ret = dwc3_gadget_soft_disconnect(dwc);

if (ret) {

      if (dwc->softconnect)

                 dwc3_gadget_soft_connect(dwc);

      return ret;

}

spin_lock_irqsave(&dwc->lock, flags);

if (dwc->gadget_driver)

       dwc3_disconnect_gadget(dwc);

spin_unlock_irqrestore(&dwc->lock, flags);





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux