Hi Xu, kernel test robot noticed the following build warnings: [auto build test WARNING on usb/usb-testing] [also build test WARNING on usb/usb-next usb/usb-linus hid/for-next westeri-thunderbolt/next linus/master v6.7 next-20240112] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Xu-Yang/usb-roles-try-to-get-put-all-relevant-modules/20240112-155735 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing patch link: https://lore.kernel.org/r/20240112080108.1147450-1-xu.yang_2%40nxp.com patch subject: [PATCH] usb: roles: try to get/put all relevant modules config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20240115/202401150608.0Ok2pmGw-lkp@xxxxxxxxx/config) compiler: clang version 18.0.0git (https://github.com/llvm/llvm-project 9bde5becb44ea071f5e1fa1f5d4071dc8788b18c) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240115/202401150608.0Ok2pmGw-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202401150608.0Ok2pmGw-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/usb/roles/class.c:37:6: warning: no previous prototype for function 'usb_role_switch_get_modules' [-Wmissing-prototypes] 37 | void usb_role_switch_get_modules(struct device *dev) | ^ drivers/usb/roles/class.c:37:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 37 | void usb_role_switch_get_modules(struct device *dev) | ^ | static >> drivers/usb/roles/class.c:46:6: warning: no previous prototype for function 'usb_role_switch_put_modules' [-Wmissing-prototypes] 46 | void usb_role_switch_put_modules(struct device *dev) | ^ drivers/usb/roles/class.c:46:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 46 | void usb_role_switch_put_modules(struct device *dev) | ^ | static 2 warnings generated. vim +/usb_role_switch_get_modules +37 drivers/usb/roles/class.c 36 > 37 void usb_role_switch_get_modules(struct device *dev) 38 { 39 while (dev) { 40 if (dev->driver) 41 WARN_ON(!try_module_get(dev->driver->owner)); 42 dev = dev->parent; 43 } 44 } 45 > 46 void usb_role_switch_put_modules(struct device *dev) 47 { 48 while (dev) { 49 if (dev->driver) 50 module_put(dev->driver->owner); 51 dev = dev->parent; 52 } 53 } 54 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
