Re: [bug report] xhci: add support to allocate several interrupters

[Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>]

Hi

On 10.1.2024 13.31, Dan Carpenter wrote:
> Hello Mathias Nyman,
>
> The patch c99b38c41234: "xhci: add support to allocate several
> interrupters" from Jan 2, 2024 (linux-next), leads to the following
> Smatch static checker warning:
>
> 	drivers/usb/host/xhci-mem.c:1873 xhci_remove_secondary_interrupter()
> 	error: we previously assumed 'ir' could be null (see line 1865)
>
> drivers/usb/host/xhci-mem.c
>      1863
>      1864         /* interrupter 0 is primary interrupter, don't touch it */
>      1865         if (!ir || !ir->intr_num || ir->intr_num >= xhci->max_interrupters)
>      1866                 xhci_dbg(xhci, "Invalid secondary interrupter, can't remove\n");
>
> This debug message is kind of pointless...  The Oops will have the stack
> trace already.

Ah, there's a return statement missing here.

Thanks for the report
Mathias