> -----Original Message----- > From: Conor Dooley <conor@xxxxxxxxxx> > Sent: Monday, January 8, 2024 8:01 PM > To: Elad Nachman <enachman@xxxxxxxxxxx> > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: Re: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5 > > On Mon, Jan 08, 2024 at 05:47:24PM +0000, Elad Nachman wrote: > > > > > > > -----Original Message----- > > > From: Conor Dooley <conor@xxxxxxxxxx> > > > Sent: Monday, January 8, 2024 7:15 PM > > > To: Elad Nachman <enachman@xxxxxxxxxxx> > > > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; > > > krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > > > devicetree@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux- > > > kernel@xxxxxxxxxxxxxxx > > > Subject: [EXT] Re: [PATCH] dt-bindings: usb: Add Marvell ac5 > > > > > > External Email > > > > > > -------------------------------------------------------------------- > > > -- On Sun, Jan 07, 2024 at 05:25:57PM +0200, Elad Nachman wrote: > > > > From: Elad Nachman <enachman@xxxxxxxxxxx> > > > > > > > > Add Marvell ac5 device tree bindings to generic EHCI. > > > > This compatible enables the Marvell Orion platform code to > > > > properly configure the DMA mask for the Marvell AC5 SOC. > > > > > > > > Signed-off-by: Elad Nachman <enachman@xxxxxxxxxxx> > > > > > > Maybe I am dumb, but I don't understand how this does what the > > > commit message says. There's no fallback to generic-ehci or any > > > other compatible that is already understood by the driver. > > > > > > What am I missing? > > > > Following guidance by Andrew Lunn on my mmc patchset, I have split the > > patchset Into a single patch for dt-bindings review and another for USB > driver review. > > I don't understand that advice. dt-bindings should (almost) always be with > the driver. Otherwise you just confuse people like me. > > Perhaps Andrew meant sending dt*s* patches separately from the driver & > bindings? The rational was different people making the actual merge, into different intermediate git REPOs, before mering into linux-next. > > Cheers, > Conor. > > > > > The USB driver patch utilizing this new dt bindings compatible string is here: > > > > https://patchwork.kernel.org/project/linux-usb/patch/20240107163307.36 > > 77347-1-enachman@xxxxxxxxxxx/ > > > > > > > > > --- > > > > Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > > b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > > index 87986c45be88..2ed178f16a78 100644 > > > > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > > @@ -77,6 +77,7 @@ properties: > > > > - const: usb-ehci > > > > - enum: > > > > - generic-ehci > > > > + - marvell,ac5-ehci > > > > - marvell,armada-3700-ehci > > > > - marvell,orion-ehci > > > > - nuvoton,npcm750-ehci > > > > -- > > > > 2.25.1 > > > > > > > > Elad. Elad.
