On Fri, Jan 05, 2024 at 01:56:35PM +0200, Niko Mauno wrote: > On 4.1.2024 18.41, Greg KH wrote: > > On Thu, Jan 04, 2024 at 06:32:03PM +0200, niko.mauno@xxxxxxxxxxx wrote: > ... > > > + The available values have the following meanings: > > > + -1 is authorized for all devices (leftover from wireless USB) > > > + 0 is unauthorized for all devices > > > + 1 is authorized for all devices > > > > What's the difference now between -1 and 1? We don't have wireless USB > > anymore as that never turned into an actual product, so we shouldn't > > reference it anymore, right? > > > > We should get rid of the -1 option entirely, but keep the module option > > and properly map it to '1'. > > > > > > > + 2 is authorized for internal devices > > > > Needs a "if you don't know what to select, please choose X" text here. > > Thanks, submitted v2 which strives to address also these considerations. Much better, thanks. I'll look at them after 6.8-rc1 is out. greg k-h
