Hi Michał, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Micha-Kope/platform-x86-serial-multi-instantiate-allow-single-GpioInt-IRQ-for-INT3515/20231212-184116 base: https://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git next patch link: https://lore.kernel.org/r/20231212103823.546118-2-michal.kopec%403mdeb.com patch subject: [PATCH] platform/x86: serial-multi-instantiate: allow single GpioInt IRQ for INT3515 config: x86_64-randconfig-161-20231219 (https://download.01.org/0day-ci/archive/20231220/202312200538.fJidUMf0-lkp@xxxxxxxxx/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202312200538.fJidUMf0-lkp@xxxxxxxxx/ smatch warnings: drivers/platform/x86/serial-multi-instantiate.c:79 smi_get_irq() warn: add some parenthesis here? drivers/platform/x86/serial-multi-instantiate.c:79 smi_get_irq() warn: maybe use && instead of & vim +79 drivers/platform/x86/serial-multi-instantiate.c 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 52 static int smi_get_irq(struct platform_device *pdev, struct acpi_device *adev, 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 53 const struct smi_instance *inst) e64e84987de5486 drivers/platform/x86/i2c-multi-instantiate.c Hans de Goede 2018-08-09 54 { 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 55 int ret; e64e84987de5486 drivers/platform/x86/i2c-multi-instantiate.c Hans de Goede 2018-08-09 56 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 57 switch (inst->flags & IRQ_RESOURCE_TYPE) { 676b7c5ecab3627 drivers/platform/x86/serial-multi-instantiate.c David Xu 2023-07-13 58 case IRQ_RESOURCE_AUTO: 676b7c5ecab3627 drivers/platform/x86/serial-multi-instantiate.c David Xu 2023-07-13 59 ret = acpi_dev_gpio_irq_get(adev, inst->irq_idx); 676b7c5ecab3627 drivers/platform/x86/serial-multi-instantiate.c David Xu 2023-07-13 60 if (ret > 0) { 676b7c5ecab3627 drivers/platform/x86/serial-multi-instantiate.c David Xu 2023-07-13 61 dev_dbg(&pdev->dev, "Using gpio irq\n"); 676b7c5ecab3627 drivers/platform/x86/serial-multi-instantiate.c David Xu 2023-07-13 62 break; 676b7c5ecab3627 drivers/platform/x86/serial-multi-instantiate.c David Xu 2023-07-13 63 } fef1688e82fe3ee drivers/platform/x86/serial-multi-instantiate.c Michał Kopeć 2023-12-12 64 ret = platform_get_irq_optional(pdev, inst->irq_idx); 676b7c5ecab3627 drivers/platform/x86/serial-multi-instantiate.c David Xu 2023-07-13 65 if (ret > 0) { 676b7c5ecab3627 drivers/platform/x86/serial-multi-instantiate.c David Xu 2023-07-13 66 dev_dbg(&pdev->dev, "Using platform irq\n"); 676b7c5ecab3627 drivers/platform/x86/serial-multi-instantiate.c David Xu 2023-07-13 67 break; 676b7c5ecab3627 drivers/platform/x86/serial-multi-instantiate.c David Xu 2023-07-13 68 } 676b7c5ecab3627 drivers/platform/x86/serial-multi-instantiate.c David Xu 2023-07-13 69 break; 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 70 case IRQ_RESOURCE_GPIO: 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 71 ret = acpi_dev_gpio_irq_get(adev, inst->irq_idx); 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 72 break; 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 73 case IRQ_RESOURCE_APIC: fef1688e82fe3ee drivers/platform/x86/serial-multi-instantiate.c Michał Kopeć 2023-12-12 74 ret = platform_get_irq_optional(pdev, inst->irq_idx); 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 75 break; 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 76 default: 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 77 return 0; e64e84987de5486 drivers/platform/x86/i2c-multi-instantiate.c Hans de Goede 2018-08-09 78 } fef1688e82fe3ee drivers/platform/x86/serial-multi-instantiate.c Michał Kopeć 2023-12-12 @79 if (ret < 0 && !inst->flags & IRQ_OPTIONAL) Precedence bug. This should be: if (ret < 0 && !(inst->flags & IRQ_OPTIONAL)) 14a9aa99aca6c28 drivers/platform/x86/serial-multi-instantiate.c Andy Shevchenko 2022-07-10 80 return dev_err_probe(&pdev->dev, ret, "Error requesting irq at index %d\n", 14a9aa99aca6c28 drivers/platform/x86/serial-multi-instantiate.c Andy Shevchenko 2022-07-10 81 inst->irq_idx); 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 82 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 83 return ret; 35a36cbb7b1ce75 drivers/platform/x86/serial-multi-instantiate.c Lucas Tanure 2022-01-21 84 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
