On Thu Dec 21, 2023 at 1:53 PM CET, Konrad Dybcio wrote: > On 21.12.2023 11:34, Dmitry Baryshkov wrote: > > On Thu, 21 Dec 2023 at 09:33, Luca Weiss <luca.weiss@xxxxxxxxxxxxx> wrote: > >> > >> On Wed Dec 20, 2023 at 1:32 PM CET, Konrad Dybcio wrote: > >>> On 20.12.2023 11:02, Luca Weiss wrote: > >>>> This series adds all the necessary bits to enable USB-C role switching, > >>>> charger and fuel gauge (all via pmic-glink) on Fairphone 5. > >>>> > >>>> One thing that could be made different is the pmic-glink compatible. > >>>> I've chosen to use qcm6490 compatible for it and not sc7280 since > >>>> there's plenty of firmware variety on sc7280-based platforms and they > >>>> might require different quirks in the future, so limit this PDOS quirk > >>>> to just qcm6490 for now. > >>>> > >>>> If someone thinks it should be qcom,sc7280-pmic-glink, please let me > >>>> know :) > >>> IMO it's best to continue using the "base soc" (which just so happened > >>> to fall onto sc7280 this time around) for all compatibles, unless the > >>> derivatives actually had changes > >> > >> Hi Konrad, > >> > >> I think at some point I asked Dmitry what he thought and he mentioned > >> qcm6490. Even found the message again: > >> > >>> well, since it is a firmware thing, you might want to emphasise that. > >>> So from my POV qcm6490 makes more sense > >> > >> But yeah since it's likely that sc7280 firmware behaves the same as > >> qcm6490 firmware it's probably okay to use sc7280 compatible, worst case > >> we change it later :) I'll send a v2 with those changes. > > > > Worst case we end up with sc7280 which has yet another slightly > > different UCSI / PMIC GLINK implementation, but the compatible string > > is already taken. > > I still suppose that this should be a qcm6490-related string. > Right, let's keep qcm then Ack from my side also. Thanks for the feedback! > > Konrad
