On Mon, 7 Dec 2009 00:10:25 -0700 Pete Zaitcev <zaitcev@xxxxxxxxxx> wrote: > On Sun, 6 Dec 2009 00:04:35 +0000 > Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote: > > > > I suppose cdc-acm should do likewise, shouldn't it? > > > > Looking at the code ACM seems to carefully wait for all the URBS to come > > in so if the ACM hardware returns the URB at the point it has left any > > internal buffering then the current code looks correct. > > Speaking of cdc-acm.c, why is it that acm_port_down is always called > with the "drain" argument set to zero (2.6.32-rc7)? Its already handled by ->chars_in_buffer with the standardised open/close logic. Once we are sure that is behaving happily the old code can go. Until then I kept it. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
