Hi Michał, kernel test robot noticed the following build warnings: [auto build test WARNING on westeri-thunderbolt/next] [also build test WARNING on linus/master v6.7-rc5 next-20231212] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Micha-Kope/platform-x86-serial-multi-instantiate-allow-single-GpioInt-IRQ-for-INT3515/20231212-184116 base: https://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git next patch link: https://lore.kernel.org/r/20231212103823.546118-2-michal.kopec%403mdeb.com patch subject: [PATCH] platform/x86: serial-multi-instantiate: allow single GpioInt IRQ for INT3515 config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231213/202312130609.vkwtG6qJ-lkp@xxxxxxxxx/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231213/202312130609.vkwtG6qJ-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202312130609.vkwtG6qJ-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/platform/x86/serial-multi-instantiate.c:79:17: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] if (ret < 0 && !inst->flags & IRQ_OPTIONAL) ^ ~ drivers/platform/x86/serial-multi-instantiate.c:79:17: note: add parentheses after the '!' to evaluate the bitwise operator first if (ret < 0 && !inst->flags & IRQ_OPTIONAL) ^ ( ) drivers/platform/x86/serial-multi-instantiate.c:79:17: note: add parentheses around left hand side expression to silence this warning if (ret < 0 && !inst->flags & IRQ_OPTIONAL) ^ ( ) 1 warning generated. vim +79 drivers/platform/x86/serial-multi-instantiate.c 51 52 static int smi_get_irq(struct platform_device *pdev, struct acpi_device *adev, 53 const struct smi_instance *inst) 54 { 55 int ret; 56 57 switch (inst->flags & IRQ_RESOURCE_TYPE) { 58 case IRQ_RESOURCE_AUTO: 59 ret = acpi_dev_gpio_irq_get(adev, inst->irq_idx); 60 if (ret > 0) { 61 dev_dbg(&pdev->dev, "Using gpio irq\n"); 62 break; 63 } 64 ret = platform_get_irq_optional(pdev, inst->irq_idx); 65 if (ret > 0) { 66 dev_dbg(&pdev->dev, "Using platform irq\n"); 67 break; 68 } 69 break; 70 case IRQ_RESOURCE_GPIO: 71 ret = acpi_dev_gpio_irq_get(adev, inst->irq_idx); 72 break; 73 case IRQ_RESOURCE_APIC: 74 ret = platform_get_irq_optional(pdev, inst->irq_idx); 75 break; 76 default: 77 return 0; 78 } > 79 if (ret < 0 && !inst->flags & IRQ_OPTIONAL) 80 return dev_err_probe(&pdev->dev, ret, "Error requesting irq at index %d\n", 81 inst->irq_idx); 82 83 return ret; 84 } 85 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
