Hi RD, kernel test robot noticed the following build errors: [auto build test ERROR on 5e4c8814a431d21bfaf20b464134f40f2f81e152] url: https://github.com/intel-lab-lkp/linux/commits/RD-Babiera/usb-typec-bus-provide-transmit-type-for-alternate-mode-drivers/20231207-171114 base: 5e4c8814a431d21bfaf20b464134f40f2f81e152 patch link: https://lore.kernel.org/r/20231207090738.15721-14-rdbabiera%40google.com patch subject: [PATCH v1 02/10] usb: typec: tcpci: enable reception of SOP' messages config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20231208/202312080751.GDJHcwNz-lkp@xxxxxxxxx/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231208/202312080751.GDJHcwNz-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202312080751.GDJHcwNz-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/usb/typec/tcpm/fusb302.c:1470:39: error: too few arguments to function call, expected 3, have 2 tcpm_pd_receive(chip->tcpm_port, msg); ~~~~~~~~~~~~~~~ ^ include/linux/usb/tcpm.h:172:6: note: 'tcpm_pd_receive' declared here void tcpm_pd_receive(struct tcpm_port *port, ^ 1 error generated. -- >> drivers/usb/typec/tcpm/wcove.c:538:37: error: too few arguments to function call, expected 3, have 2 tcpm_pd_receive(wcove->tcpm, &msg); ~~~~~~~~~~~~~~~ ^ include/linux/usb/tcpm.h:172:6: note: 'tcpm_pd_receive' declared here void tcpm_pd_receive(struct tcpm_port *port, ^ 1 error generated. -- >> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c:302:52: error: too few arguments to function call, expected 3, have 2 tcpm_pd_receive(pmic_typec_pdphy->tcpm_port, &msg); ~~~~~~~~~~~~~~~ ^ include/linux/usb/tcpm.h:172:6: note: 'tcpm_pd_receive' declared here void tcpm_pd_receive(struct tcpm_port *port, ^ 1 error generated. vim +1470 drivers/usb/typec/tcpm/fusb302.c c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1421 c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1422 static int fusb302_pd_read_message(struct fusb302_chip *chip, c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1423 struct pd_message *msg) c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1424 { c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1425 int ret = 0; c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1426 u8 token; c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1427 u8 crc[4]; c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1428 int len; c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1429 c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1430 /* first SOP token */ c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1431 ret = fusb302_i2c_read(chip, FUSB_REG_FIFOS, &token); c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1432 if (ret < 0) c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1433 return ret; c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1434 ret = fusb302_i2c_block_read(chip, FUSB_REG_FIFOS, 2, c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1435 (u8 *)&msg->header); c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1436 if (ret < 0) c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1437 return ret; f03d95f59026d1 drivers/staging/typec/fusb302/fusb302.c Guru Das Srinagesh 2017-05-10 1438 len = pd_header_cnt_le(msg->header) * 4; c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1439 /* add 4 to length to include the CRC */ c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1440 if (len > PD_MAX_PAYLOAD * 4) { c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1441 fusb302_log(chip, "PD message too long %d", len); c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1442 return -EINVAL; c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1443 } c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1444 if (len > 0) { c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1445 ret = fusb302_i2c_block_read(chip, FUSB_REG_FIFOS, len, c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1446 (u8 *)msg->payload); c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1447 if (ret < 0) c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1448 return ret; c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1449 } c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1450 /* another 4 bytes to read CRC out */ c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1451 ret = fusb302_i2c_block_read(chip, FUSB_REG_FIFOS, 4, crc); c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1452 if (ret < 0) c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1453 return ret; c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1454 fusb302_log(chip, "PD message header: %x", msg->header); c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1455 fusb302_log(chip, "PD message len: %d", len); c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1456 ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1457 /* ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1458 * Check if we've read off a GoodCRC message. If so then indicate to ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1459 * TCPM that the previous transmission has completed. Otherwise we pass ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1460 * the received message over to TCPM for processing. ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1461 * ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1462 * We make this check here instead of basing the reporting decision on ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1463 * the IRQ event type, as it's possible for the chip to report the ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1464 * TX_SUCCESS and GCRCSENT events out of order on occasion, so we need ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1465 * to check the message type to ensure correct reporting to TCPM. ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1466 */ ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1467 if ((!len) && (pd_header_type_le(msg->header) == PD_CTRL_GOOD_CRC)) ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1468 tcpm_pd_transmit_complete(chip->tcpm_port, TCPC_TX_SUCCESS); ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1469 else ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 @1470 tcpm_pd_receive(chip->tcpm_port, msg); ab69f61321140f drivers/usb/typec/fusb302/fusb302.c Adam Thomson 2017-11-21 1471 c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1472 return ret; c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1473 } c034a43e72dda5 drivers/staging/typec/fusb302/fusb302.c Yueyao Zhu 2017-04-27 1474 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
