On Thu, Dec 07, 2023 at 03:44:41PM +0200, Tasos Sahanidis wrote:
> This flash drive reports write protect during the first mode sense.
>
> In the past this was not an issue as the kernel called revalidate twice,
> thus asking the device for its write protect status twice, with write
> protect being disabled in the second mode sense.
>
> However, since commit 1e029397d12f ("scsi: sd: Reorganize DIF/DIX code to
> avoid calling revalidate twice") that is no longer the case, thus the
> device shows up read only.
>
> [490891.289495] sd 12:0:0:0: [sdl] Write Protect is on
> [490891.289497] sd 12:0:0:0: [sdl] Mode Sense: 2b 00 80 08
>
> This does not appear to be a timing issue, as enabling the usbcore quirk
> USB_QUIRK_DELAY_INIT has no effect on write protect.
>
> Fixes: 1e029397d12f ("scsi: sd: Reorganize DIF/DIX code to avoid calling revalidate twice")
> Signed-off-by: Tasos Sahanidis <tasos@xxxxxxxxxxxx>
> ---
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> drivers/usb/storage/unusual_devs.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 20dcbccb290b..fd68204374f2 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -1305,6 +1305,17 @@ UNUSUAL_DEV( 0x090c, 0x6000, 0x0100, 0x0100,
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> US_FL_INITIAL_READ10 ),
>
> +/*
> + * Patch by Tasos Sahanidis <tasos@xxxxxxxxxxxx>
> + * This flash drive always shows up with write protect enabled
> + * during the first mode sense.
> + */
> +UNUSUAL_DEV(0x0951, 0x1697, 0x0100, 0x0100,
> + "Kingston",
> + "DT Ultimate G3",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> + US_FL_NO_WP_DETECT),
> +
> /*
> * This Pentax still camera is not conformant
> * to the USB storage specification: -
> --
> 2.25.1
>
