On 12/6/23 04:38, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@xxxxxxxx> > > DRM_AUX_BRIDGE depends on CONFIG_OF, so the same dependency is needed > here to avoid a build failure: > > WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] > Selected by [y]: > - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y] > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_register': > aux-bridge.c:(.text+0x13b): undefined reference to `auxiliary_device_init' > x86_64-linux-ld: aux-bridge.c:(.text+0x14d): undefined reference to `__auxiliary_device_add' > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_init': > aux-bridge.c:(.init.text+0x15): undefined reference to `__auxiliary_driver_register' > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_exit': > aux-bridge.c:(.exit.text+0x9): undefined reference to `auxiliary_driver_unregister' > > Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Thanks. > --- > drivers/usb/typec/mux/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig > index 5120942f309d..818624f59120 100644 > --- a/drivers/usb/typec/mux/Kconfig > +++ b/drivers/usb/typec/mux/Kconfig > @@ -40,6 +40,7 @@ config TYPEC_MUX_NB7VPQ904M > tristate "On Semiconductor NB7VPQ904M Type-C redriver driver" > depends on I2C > depends on DRM || DRM=n > + depends on OF > select DRM_AUX_BRIDGE if DRM_BRIDGE > select REGMAP_I2C > help -- ~Randy