On 12/4/23 09:04, Conor Dooley wrote:
On Sun, Dec 03, 2023 at 05:56:24PM +0100, Stefan Wahren wrote:Hi, Am 03.12.23 um 12:11 schrieb Conor Dooley:On Sun, Dec 03, 2023 at 11:06:43AM +0000, Conor Dooley wrote:On Sun, Dec 03, 2023 at 12:22:15AM +0100, Stefan Wahren wrote:The xHCI IP on the BCM2711 SoC is compatible to "brcm,xhci-brcm-v2", but also requires a power domain.Hmm This & the driver change makes it look like your compatible setup should be `compatible = "brcm,bcm2711-xhci", "brcm,xhci-brcm-v2";.i don't have insight into the hardware, but the fact that the other Broadcom SoC didn't require a power domain before let me think we shouldn't do this. Otherwise this binding was broken before. But Justin and Florian could clarify this.
That seems to me like the right approach, the XHCI controller in 2711 is tied to a power domain, however that is not the case for other Broadcom STB SoCs.
If the pattern in this patch was repeated, we'd have to modify the driver like your 2nd patch does for each and new broadcom system that needs the power domain.From my understanding the DT compatible should be specific as possible.Note that I am suggesting have 2 compatibles. One specific, falling back to the existing generic one.
We could do that, yes. -- Florian
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
