On Mon, Dec 04, 2023 at 04:25:43PM +0100, Hardik Gajjar wrote: > On Mon, Dec 04, 2023 at 08:02:50AM +0100, Greg KH wrote: > > And why not use BIT() as that's what these are. > > > > thanks, > > > > greg k-h > > I am considering aligning with existing quirks. > Is it advisable to use something like HUB_QUIRK_REDUCE_FRAME_INTR_BINTERVAL BIT(2)? > I'm thinking to submit two patches – one to replace hard values with BIT() in existing quirks and a second patch containing my changes. That's a good idea. Alan Stern