On 11/27/23 17:08, Simon Holesch wrote:
Skip submitting URBs, when identical requests were already sent in tweak_special_requests(). Instead call the completion handler directly to return the result of the URB.
Sounds reasonable. What happens when a tweak_* routine does nothing or returns an error. tweak_reset_device_cmd() returns 0 when it can't get the device lock and after calling usb_reset_device(). tweak_set_interface_cmd() and tweak_clear_halt_cmd() return the value the usb_* routine they call. Don't these cases be handled as well? thanks, -- Shuah
