RE: [RFC PATCH v2 2/2] kselftest: devices: Add sample board file for google,spherion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
> Add a sample board file describing the file's format and with the list
> of devices expected to be probed on the google,spherion machine as an
> example.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
> ---
> 
> (no changes since v1)
> 
>  .../testing/selftests/devices/boards/google,spherion | 12 ++++++++++++

Overall, while trying to maintain a comprehensive set of board definitions
seems hard, I think having a few as examples is useful.

I'm not a big fan of naming these with a comma in the name.  Is there a reason
you are not using dash or underscore?

Do you anticipate a convention of  <producer> <board-or-product-name> tuples for
the filename?
 -- Tim

>  1 file changed, 12 insertions(+)
>  create mode 100644 tools/testing/selftests/devices/boards/google,spherion
> 
> diff --git a/tools/testing/selftests/devices/boards/google,spherion b/tools/testing/selftests/devices/boards/google,spherion
> new file mode 100644
> index 000000000000..db9a17cccd03
> --- /dev/null
> +++ b/tools/testing/selftests/devices/boards/google,spherion
> @@ -0,0 +1,12 @@
> +# Example test definition for Google Spherion Chromebook
> +#
> +# Format:
> +#   usb|pci test_name number_of_matches field=value [ field=value ... ]
> +#
> +# The available match fields vary by bus. The field-value match pairs for a
> +# device can be retrieved from the device's modalias attribute in sysfs. A
> +# subset of the fields may be used to make the match more generic so it can work
> +# with the different hardware variants of a device on the machine.
> +usb camera 1 ic=0e isc=01 ip=00
> +usb bluetooth 1 ic=e0 isc=01 ip=01 in=00
> +pci wifi 1 v=14c3 d=7961
> --
> 2.42.1





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux