On 11/26/23 16:48, Simon Holesch wrote:
Even though submitting those requests twice should be harmless, there
are USB devices that react poorly to some duplicated requests.
The change looks good to me. I want to see the change explained in
the commit log. I see the information on why the change is needed.
Please add a bit more information on the change.
One example is the ChipIdea controller implementation in U-Boot: The
second SET_CONFIURATION request makes U-Boot disable and re-enable all
endpoints. Re-enabling an endpoint in the ChipIdea controller, however,
was broken until U-Boot commit b272c8792502 ("usb: ci: Fix gadget
reinit").
Signed-off-by: Simon Holesch <simon@xxxxxxxxxx>
thanks,
-- Shuah
