Hi,
On 2023/11/4 07:03, Dmitry Baryshkov wrote:
Supporting DP/USB-C can result in a chain of several transparent
bridges (PHY, redrivers, mux, etc). All attempts to implement DP support
in a different way resulted either in series of hacks or in device tree
not reflecting the actual hardware design. This results in drivers
having similar boilerplate code for such bridges.
Please improve the written, "resulted" -> "yield" ?
Next, these drivers are susceptible to -EPROBE_DEFER loops: the next
bridge can either be probed from the bridge->attach callback, when it is
too late to return -EPROBE_DEFER, or from the probe() callback, when the
next bridge might not yet be available, because it depends on the
resources provided by the probing device. Device links can not fully
solve this problem since there are mutual dependencies between adjancent
devices.
Last, but not least, this results in the the internal knowledge of DRM
There is a duplicated "the" word in this sentence.
As far as I can understand, nearly all of those troubles are because the display bridges
drivers are designed as a kernel module(.ko) instead of making them as static link-able
helpers. I means that a display bridge device can not work standalone, as it have to be
used with a display controller. So a display bridge is just a slave device or a auxiliary
device. My question is: if it can't works by itself, we probably shouldn't design them as
kernel modules style. Am I correct?
subsystem slowly diffusing into other subsystems, like PHY or USB/TYPEC.
Yeah, this indeed a problem.
To solve all these issues, define a separate DRM helper, which creates
separate aux device just for the bridge.
I'm supporting you if want to solve all these problems, this is fine and thanks a lot.
But I want to ask a question, now that you are solving these problems by creating separate
devices, does this manner match the hardware design perfectly? which is the hardware units
you newly created device is corresponding to?
During probe such aux device
doesn't result in the EPROBE_DEFER loops. Instead it allows the device
drivers to probe properly, according to the actual resource
dependencies. The bridge auxdevs are then probed when the next bridge
becomes available, sparing drivers from drm_bridge_attach() returning
-EPROBE_DEFER.
OK, as far as I can understand, in order to solve the mentioned problem
you are also retire the defer probe mechanism.
Changes since v5:
- Removed extra semicolon in !DRM_AUX_HPD_BRIDGE stubs definition.
Changes since v4:
- Added documentation for new API (Sima)
- Added generic code to handle "last mile" DP bridges implementing just
the HPD functionality.
- Rebased on top of linux-next to be able to drop #ifdef's around
drm_bridge->of_node
Changes since v3:
- Moved bridge driver to gpu/drm/bridge (Neil Armstrong)
- Renamed it to aux-bridge (since there is already a simple_bridge driver)
- Made CONFIG_OF mandatory for this driver (Neil Armstrong)
- Added missing kfree and ida_free (Dan Carpenter)
Changes since v2:
- ifdef'ed bridge->of_node access (LKP)
Changes since v1:
- Added EXPORT_SYMBOL_GPL / MODULE_LICENSE / etc. to drm_simple_bridge
Dmitry Baryshkov (6):
drm/bridge: add transparent bridge helper
phy: qcom: qmp-combo: switch to DRM_AUX_BRIDGE
usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE
drm/bridge: implement generic DP HPD bridge
soc: qcom: pmic-glink: switch to DRM_AUX_HPD_BRIDGE
usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE
drivers/gpu/drm/bridge/Kconfig | 17 ++
drivers/gpu/drm/bridge/Makefile | 2 +
drivers/gpu/drm/bridge/aux-bridge.c | 140 +++++++++++++++
drivers/gpu/drm/bridge/aux-hpd-bridge.c | 164 ++++++++++++++++++
drivers/phy/qualcomm/Kconfig | 2 +-
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 44 +----
drivers/soc/qcom/Kconfig | 1 +
drivers/soc/qcom/pmic_glink_altmode.c | 33 +---
drivers/usb/typec/mux/Kconfig | 2 +-
drivers/usb/typec/mux/nb7vpq904m.c | 44 +----
drivers/usb/typec/tcpm/Kconfig | 1 +
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 41 +----
include/drm/bridge/aux-bridge.h | 37 ++++
13 files changed, 383 insertions(+), 145 deletions(-)
create mode 100644 drivers/gpu/drm/bridge/aux-bridge.c
create mode 100644 drivers/gpu/drm/bridge/aux-hpd-bridge.c
create mode 100644 include/drm/bridge/aux-bridge.h
