On Mon, Oct 16, 2023 at 08:11:15PM -0700, Bjorn Andersson wrote: > The Qualcomm DWC3 glue builds up a platform_device programmatically in > order to probe the DWC3 core when running off ACPI data. But with the > newly introduced support for instantiating the core directly from the > glue, this code can be replaced with a single function call. > > Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> > --- > @@ -986,10 +933,10 @@ static int dwc3_qcom_probe(struct platform_device *pdev) > interconnect_exit: > dwc3_qcom_interconnect_exit(qcom); > depopulate: > - if (np) > + if (qcom->dwc_dev) > of_platform_depopulate(&pdev->dev); > else > - platform_device_put(pdev); > + dwc3_remove(qcom->dwc); The current code was broken here too: https://lore.kernel.org/linux-usb/20231117173650.21161-2-johan+linaro@xxxxxxxxxx/ Johan
