Hello Krzysztof,
On Mon Nov 20, 2023 at 6:31 PM CET, Krzysztof Kozlowski wrote:
> On 20/11/2023 18:06, Théo Lebrun wrote:
[...]
> > --- a/drivers/usb/cdns3/cdns3-ti.c
> > +++ b/drivers/usb/cdns3/cdns3-ti.c
> > static const int cdns_ti_rate_table[] = { /* in KHZ */
> > @@ -172,6 +173,7 @@ static int cdns_ti_probe(struct platform_device *pdev)
> > data->usb2_refclk_rate_code = i;
> > data->vbus_divider = device_property_read_bool(dev, "ti,vbus-divider");
> > data->usb2_only = device_property_read_bool(dev, "ti,usb2-only");
> > + data->reset_on_resume = of_device_is_compatible(node, "ti,j7200-usb");
>
> No, use driver data for this. Don't put compatibles in the code. It
> makes it unmanageable soon.
Fixed for next revision. I hesitated on this patch but I'll know for
next time.
Thanks,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
