Re: [PATCH] usb: misc: ljca: Fix enumeration error on Dell Latitude 9420

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 02, 2023 at 07:05:33PM +0100, Hans de Goede wrote:
> > 
> >>  	ret = ljca_send(adap, LJCA_CLIENT_MNG, LJCA_MNG_ENUM_SPI, NULL, 0, buf,
> >>  			sizeof(buf), true, LJCA_ENUM_CLIENT_TIMEOUT_MS);
> >>  	if (ret < 0)
> >> -		return ret;
> >> +		return (ret == -ETIMEDOUT) ? 0 : ret;
> > 
> >    I don't think the parens are necessary.
> 
> They are not strictly necessary, but IMHO the code is more readable with
> the parens.

I agree, please leave it in.

thanks,

greg k-h




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux