On Fri, Oct 27, 2023 at 11:57:35AM +0200, Hardik Gajjar wrote: > On Thu, Oct 26, 2023 at 02:34:22PM -0400, Alan Stern wrote: > > As remarked earlier, we don't need to have the "_MS" suffix on either > > the macro name or the "timeout_ms" variable name. Removing the suffix > > will be more consistent with the USB_TP_TRANSMISSION_DELAY_MAX and > > USB_PING_RESPONSE_TIME names you see above. > > I understand the suffix _MS in macro but the suffix is variable name was > added after the comment about timeout unit from Greg in patchV2. > > https://marc.info/?l=linux-usb&m=169687322126192&w=2 Greg merely wanted you to document what the timeout units are. You can do this either by adding a "_ms" suffix to the variable name or by mentioning it in a comment. For example: + unsigned int timeout = USB_CTRL_SET_TIMEOUT; /* ms */ Alan Stern
