Re: [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27/10/2023 20:05, Greg KH wrote:
> On Fri, Oct 27, 2023 at 07:56:53PM +0700, Bagas Sanjaya wrote:
>> On Fri, Oct 27, 2023 at 03:37:51PM +0300, LihaSika wrote:
>>>> - Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
>>>>    and can not be applied.  Please read the file,
>>>>    Documentation/process/email-clients.rst in order to fix this.
>>>>
>>>
>>> Oh right, Thunderbird wrapped the first line of the patch file -.-
>>>
>>> Disabled wrapping, another attempt:
>>>
>>> Cc: stable@xxxxxxxxxxxxxxx
>>> Signed-off-by: Liha Sikanen <lihasika@xxxxxxxxx>
>>> ---
>>>
>>> diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h
>>> index 0547daf..7b3d5f0 100644
>>> --- a/drivers/usb/storage/unusual_cypress.h
>>> +++ b/drivers/usb/storage/unusual_cypress.h
>>> @@ -19,7 +19,7 @@ UNUSUAL_DEV(  0x04b4, 0x6831, 0x0000, 0x9999,
>>>          "Cypress ISD-300LP",
>>>          USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0),
>>>
>>> -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160,
>>> +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160,
>>>          "Super Top",
>>>          "USB 2.0  SATA BRIDGE",
>>>          USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0),
>>>
>>>
>>>
>>
>> Hi,
>>
>> You have to use git-send-email(1) for the purpose of sending patches
>> instead. Please see Documentation/process/email-clients.rst in the kernel
>> sources for more information. And don't forget to address reviews from
>> Greg's bot.
> 
> You don't have to use git send-email, that's not required at all, it's
> just there to make things easier for some people.
> 

Thanks for the tip.

IMO, this is the submitter's first patch submission where he had to set up
appropriate tooling.

-- 
An old man doll... just what I always wanted! - Clara





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux