On Tue, Oct 24, 2023 at 2:27 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Mon, Oct 23, 2023 at 02:25:30PM -0700, Avichal Rakesh wrote: > > On Sat, Oct 21, 2023 at 3:05 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > On Thu, Oct 19, 2023 at 03:30:00PM -0700, Avichal Rakesh wrote: > > > > > > > > > > > > On 10/19/23 13:32, kernel test robot wrote: > > > > > Hi Avichal, > > > > > > > > > > kernel test robot noticed the following build warnings: > > > > > > > > > > [auto build test WARNING on usb/usb-testing] > > > > > [also build test WARNING on usb/usb-next usb/usb-linus linus/master v6.6-rc6 next-20231019] > > > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > > > And when submitting patch, we suggest to use '--base' as documented in > > > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > > > > > > > url: https://github.com/intel-lab-lkp/linux/commits/Avichal-Rakesh/usb-gadget-uvc-prevent-use-of-disabled-endpoint/20231020-025512 > > > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing > > > > > patch link: https://lore.kernel.org/r/20231019185319.2714000-5-arakesh%40google.com > > > > > patch subject: [PATCH v6 4/4] usb: gadget: uvc: Fix use-after-free for inflight usb_requests > > > > > config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231020/202310200457.GwPPFuHX-lkp@xxxxxxxxx/config) > > > > > compiler: m68k-linux-gcc (GCC) 13.2.0 > > > > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231020/202310200457.GwPPFuHX-lkp@xxxxxxxxx/reproduce) > > > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > > > the same patch/commit), kindly add following tags > > > > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202310200457.GwPPFuHX-lkp@xxxxxxxxx/ > > > > > > > > > > All warnings (new ones prefixed by >>): > > > > > > > > > >>> drivers/usb/gadget/function/uvc_video.c:231: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > > > > > * Must be called with req_lock held as it modifies the list ureq is held in > > > > > > > > > > > > > > > > > > Greg, apologies for the newb question: do you want me to upload > > > > the fix for this as a reply to [PATCH v6 4/4], or upload a new chain of > > > > v7s with this patch fixed? > > > > > > A whole new v7 series please. > > > > > > > Had a feeling, so sent out v7 series preemptively. Let me know if that > > doesn't work. > > > > v7: https://lore.kernel.org/20231020173626.2978356-1-arakesh@xxxxxxxxxx/ > > I have already dropped that from my review queue as your emails crossed > with that, so I thought it was obsolete by now, sorry. > > Can you send a v8 please? > Sent out v8! PTAL when you get the chance. https://lore.kernel.org/20231024183605.908253-1-arakesh@xxxxxxxxxx/ Thank you! - Avi.
