On Wed, Dec 02, 2009 at 10:38:27PM +0300, Sergei Shtylyov wrote: > Hello. > > pancho horrillo wrote: > > >Please, review and push the patch, if you deem it adequate. > > >Thanks a bunch! > > That 'uint8_t' is for userspace, use 'u8' instead. > > WBR, Sergei Thanks for the coaching, Sergei! BTW, there are about 4863 of uint8_t in the kernel sources :-) Cheers, pancho. Signed-off-by: pancho horrillo <pancho@xxxxxxxxxxx> diff -purN a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c --- a/drivers/usb/misc/appledisplay.c 2009-11-10 01:32:31.000000000 +0100 +++ b/drivers/usb/misc/appledisplay.c 2009-12-02 20:05:00.000000000 +0100 @@ -72,8 +72,8 @@ struct appledisplay { struct usb_device *udev; /* usb device */ struct urb *urb; /* usb request block */ struct backlight_device *bd; /* backlight device */ - char *urbdata; /* interrupt URB data buffer */ - char *msgdata; /* control message data buffer */ + u8 *urbdata; /* interrupt URB data buffer */ + u8 *msgdata; /* control message data buffer */ struct delayed_work work; int button_pressed; -- pancho horrillo To be conscious that you are ignorant is a great step to knowledge. Benjamin Disraeli -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html