Re: [PATCH v4 1/3] dt-bindings: usb: add rk3588 compatible to rockchip,dwc3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Conor,

On Fri, Oct 20, 2023 at 04:36:19PM +0100, Conor Dooley wrote:
> On Fri, Oct 20, 2023 at 04:11:40PM +0200, Sebastian Reichel wrote:
> > [...]
> > +allOf:
> > +  - $ref: snps,dwc3.yaml#
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: rockchip,rk3328-dwc3
> > +    then:
> > +      properties:
> > +        clocks:
> > +          minItems: 3
> > +          maxItems: 4
> > +        clock-names:
> > +          minItems: 3
> > +          items:
> > +            - const: ref_clk
> > +            - const: suspend_clk
> > +            - const: bus_clk
> > +            - const: grf_clk
> 
> minItems for clocks and clock-names is already 3, is it not?

Yes, but the following 'maxItems: 4' implicitly sets it to 4,
so I had to set it again. The same is true for clock-names -
providings new 'items:' effectively drops the "minItems: 3"
from the generic section.

> Otherwise,
> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> 
> Thanks,
> Conor.

Thanks,

-- Sebastian

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux