Re: [PATCH] net: lan78xx: add an error code check in lan78xx_write_raw_eeprom

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023/10/19 18:34, Dan Carpenter wrote:
On Thu, Oct 19, 2023 at 04:40:23PM +0800, Su Hui wrote:
check the value of 'ret' after call 'lan78xx_read_reg'.

Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx>
---

Clang complains that value stored to 'ret' is never read.
Maybe this place miss an error code check, I'm not sure
about this.
There are a bunch more "ret = " assignments which aren't used in this
function.
Yep, same problem  exists at lan78xx_read_raw_eeprom().
I try to send v2 patch to fix this.

Su Hui





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux