On 10/16/23 19:33, Alan Stern wrote:
On Mon, Oct 16, 2023 at 09:25:57AM +0200, Milan Broz wrote:
This patchset adds support for OPAL commands (self-encrypted drives)
through USB-attached storage (usb-storage and UAS drivers).
This is version 2 of the proposed patch set, but you didn't include the
version number in the email Subject: lines and you didn't include the
summary of differences from v1 below the "---" lines of the various
patches.
Hi,
well, the first patchset was RFC, so I sent is as "the first real version".
Perhaps not the correct way, sorry for that.
Anyway, if you see the discussion about OPAL change on SCSI list, another
solution (inside USB storage driver) is needed.
So, please ignore patch 6/7, these will be needed, but I have to rewrite
SCSI logic to USB glue/UAS driver.
But for the generic 64-bit flags (patch 1-5), if you see this useful, please review it.
Common requirement is that kernel patch need an user for merge
(and my flag is currently no going to be used without rewrite).
But that time will come one day, and if I can save people time to reinvent
the 64-bit quirks logic, it would be nice to merge it.
Thanks,
Milan
Patches 5, 6, and 7 look okay. You can add my Reviewed-by: to each of
them.
I've got some additional comments on patch 4 (in a separate email).
Alan Stern
