Re: [PATCH] media: imon: fix stall in worker_thread

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 14, 2023 at 11:51:15AM +0800, Edward AD wrote:
> On Fri, 13 Oct 2023 12:59:09 +0200 Simon Horman wrote:
> > The code is already switching based on urb->status,
> > so unless the warning message is really desired,
> > perhaps this is more appropriate?
> > 
> > diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c
> > index 74546f7e3469..0e2f06f2f456 100644
> > --- a/drivers/media/rc/imon.c
> > +++ b/drivers/media/rc/imon.c
> > @@ -1799,6 +1799,7 @@ static void usb_rx_callback_intf1(struct urb *urb)
> > 
> >  	switch (urb->status) {
> >  	case -ENOENT:		/* usbcore unlink successful! */
> > +	case -EPROTO:		/* XXX: something goes here */
> >  		return;
> > 
> >  	case -ESHUTDOWN:	/* transport endpoint was shut down */
> 
> Hi Simon Horman, 
> 
> Who added the above code where?

Maybe I misunderstand your question but
I am suggesting the above change as an alternative approach.




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux