On Fri, Sep 01, 2023 at 05:36:10PM +0800, Puliang Lu wrote: > Update the USB serial option driver support for the Fibocom > FM101R-GL > LTE modules as there are actually several different variants. > - VID:PID 413C:8213, FM101R-GL are laptop M.2 cards (with > MBIM interfaces for Linux) > - VID:PID 413C:8215, FM101R-GL ESIM are laptop M.2 cards(with > MBIM interface for Linux) > > T: Bus=04 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 2 Spd=5000 MxCh= 0 > D: Ver= 3.20 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 9 #Cfgs= 1 > P: Vendor=413c ProdID=8213 Rev= 5.04 > S: Manufacturer=Fibocom Wireless Inc. > S: Product=Fibocom FM101-GL Module > S: SerialNumber=a3b7cbf0 > C:* #Ifs= 3 Cfg#= 1 Atr=a0 MxPwr=896mA > A: FirstIf#= 0 IfCount= 2 Cls=02(comm.) Sub=0e Prot=00 > I:* If#= 0 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=0e Prot=00 Driver=cdc_mbim > E: Ad=81(I) Atr=03(Int.) MxPS= 64 Ivl=32ms > I: If#= 1 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > I:* If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > E: Ad=8e(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms > E: Ad=0f(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms > I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=40 Driver=(none) > E: Ad=83(I) Atr=03(Int.) MxPS= 10 Ivl=32ms > E: Ad=82(I) Atr=02(Bulk) MxPS=1024 Ivl=0ms > E: Ad=01(O) Atr=02(Bulk) MxPS=1024 Ivl=0ms Could there ever be further vendor class interfaces (e.g. adb) so that you should be using a more specific match entry? > Signed-off-by: Puliang Lu <puliang.lu@xxxxxxxxxxx> The SoB email does not match the sender address (e.g. as checkpatch complains about). Could you resend this one from you fibocom account so that it matches? > + { USB_DEVICE_INTERFACE_CLASS(DELL_VENDOR_ID, DELL_PRODUCT_FM101R, 0xff) }, > + { USB_DEVICE_INTERFACE_CLASS(DELL_VENDOR_ID, DELL_PRODUCT_FM101R_ESIM, 0xff) }, Johan