On Tue, Oct 10, 2023 at 10:27:32AM +0200, Jerome Brunet wrote: > > On Tue 10 Oct 2023 at 08:56, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > On Fri, Oct 06, 2023 at 12:10:28PM +0200, Jerome Brunet wrote: > >> Initial tests with the gl3510 has been done on libretech aml-a311d-cc. > >> A 50us reset was fine as long as the hub node was under the usb phy node it > >> DT. DT schema does not allow that. Moving the hub under the dwc3 controller > >> caused issues, such as: > >> > >> onboard-usb-hub 1-1: Failed to suspend device, error -32 > >> onboard-usb-hub 1-1: can't set config #1, error -71 > >> onboard-usb-hub 1-1: Failed to suspend device, error -32 > >> onboard-usb-hub 1-1: USB disconnect, device number 2 > >> > >> Extending the reset duration solves the problem. > >> Since there is no documentation available for this hub, it is difficult to > >> know the actual required reset duration. 200us seems to work fine so far. > >> > >> Suggested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > >> Fixes: 65009ccf7e8f ("usb: misc: onboard_usb_hub: add Genesys Logic gl3510 hub support") > > > > I can't find this git id, what tree is it in? > > Silly mistake. I must have taken the git id I had before you merged it. Sorry. > The correct tag with usb-next is > > Fixes: b447e9efe50a ("usb: misc: onboard_usb_hub: add Genesys Logic gl3510 hub support") > > Should I resend it ? Please do.