On Mon, Oct 09, 2023 at 06:57:39PM +0200, Max Kellermann wrote: > This allows passing arrays of const pointers. The goal is to make > lots of global variables "const" to allow them to live in the > ".rodata" section. > > Signed-off-by: Max Kellermann <max.kellermann@xxxxxxxxx> In my opinion this touches way too many subsystems in a single patch. If someting is wrong with just one of the changes, it will be all but impossible to revert the whole thing. Also, I don't know why checkpatch is happy with all the const struct attribute_group *const*groups; instead of const struct attribute_group *const *groups; but I still don't like it. Guenter