On 10/5/23 00:11, Greg Kroah-Hartman wrote: > On Tue, Oct 03, 2023 at 04:16:00PM -0700, Avichal Rakesh wrote: >> Thank you for testing the patch, Michael! >> >> On 10/3/23 04:09, Michael Grzeschik wrote: >>> Hi >>> >>> On Sat, Sep 30, 2023 at 11:48:18AM -0700, Avichal Rakesh wrote: >>>> We have been seeing two main stability issues that uvc gadget driver >>>> runs into when stopping streams: >>>> 1. Attempting to queue usb_requests to a disabled usb_ep >>>> 2. use-after-free issue for inflight usb_requests >>>> >>>> The three patches below fix the two issues above. Patch 1/3 fixes the >>>> first issue, and Patch 2/3 and 3/3 fix the second issue. >>>> >>>> Avichal Rakesh (3): >>>> usb: gadget: uvc: prevent use of disabled endpoint >>>> usb: gadget: uvc: Allocate uvc_requests one at a time >>>> usb: gadget: uvc: Fix use-after-free for inflight usb_requests >>>> >>>> drivers/usb/gadget/function/f_uvc.c | 11 +- >>>> drivers/usb/gadget/function/f_uvc.h | 2 +- >>>> drivers/usb/gadget/function/uvc.h | 6 +- >>>> drivers/usb/gadget/function/uvc_v4l2.c | 21 ++- >>>> drivers/usb/gadget/function/uvc_video.c | 189 +++++++++++++++++------- >>>> 5 files changed, 164 insertions(+), 65 deletions(-) >>> >>> These patches are not applying on gregkh/usb-testing since >>> Greg did take my patches first. I have already rebased them. >> >> Ah, I didn't realize Greg had picked up your changes in his tree. >> Rebased the patches in V2. > > The "v2" series here is almost impossible to follow, sorry. > > Please send it as a new thread, not as responses to the individual > commits, how am I supposed to pick them up that way? > > And make it v3 please. Sent out v3 as a new thread. Sorry about that! - Avi.
