On Tue, Oct 03, 2023 at 09:21:08AM +0300, Heikki Krogerus wrote: > On Sun, Oct 01, 2023 at 04:11:27AM -0400, Abdel Alkuor wrote: > > From: Abdel Alkuor <abdelalkuor@xxxxxxxxxx> > > > > TPS25750 PD controller might be powered off externally at power suspend, > > after resuming PD controller power back, apply the patch again. > > > > Signed-off-by: Abdel Alkuor <abdelalkuor@xxxxxxxxxx> > > This one looks also like something that should be part of the patch 4. > > My concern is that with these separated features you are creating points > into the kernel git tree where TPS25750 is enabled, but it's not fully > functional, or even broken in scenarious like this (suspend/resume). > You can't do that unless you have some really good reason. > > Since all of these add only a bit of code each, I think it would be > better to just merge these into the initial patch that enabled > TPS25750 - so I belive patch 4/14. > Makes a lot of sense. I will add part of full tps25750 support patch > -- > heikki Thanks, Abdel
