Re: [patch]unbalanced calls to post_reset() from usb_reset_device()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 27 Nov 2009, Oliver Neukum wrote:

> > > +		/*
> > > +		 * Don't rebind until after all the post_reset() calls
> > > +		 * so that a newly bound driver does not get an unbalanced
> > > +		 * call to post_reset()
> > > +		 */
> > > +		for (i = config->desc.bNumInterfaces - 1; i >= 0; --i){
> > > +			struct usb_interface *cintf = config->interface[i];
> > > +
> > > +			/*
> > > +			 * safe w.r.t. usb_claim_interface() as
> > > +			 * that clears needs_binding
> > > +			 */
> > 
> > Hmm.  If your probe routine claims some other interfaces and then does
> > a reset, and you don't provide pre_reset and post_reset methods, you're
> > likely to run into trouble anyway.  Drivers just shouldn't do that.
> > They should carry out the reset first.
> 
> Suppose another driver is rebound.

I don't understand.  Please add more details.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux