On Wed, Sep 20, 2023 at 04:28:56PM +0800, Xiaolei Wang wrote: > The return type of cdns_set_active () is inconsistent > depending on whether CONFIG_PM_SLEEP is enabled, so the > return value is modified to void type. > > Reported-by: Pavel Machek <pavel@xxxxxxx> > Closes: https://lore.kernel.org/all/ZP7lIKUzD68XA91j@xxxxxxxxxx/ > Fixes: 2319b9c87fe2 ("usb: cdns3: Put the cdns set active part outside the spin lock") > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Xiaolei Wang <xiaolei.wang@xxxxxxxxxxxxx> > Reviewed-by: Pavel Machek <pavel@xxxxxxx> > Reviewed-by: Roger Quadros <rogerq@xxxxxxxxxx> > > v2: > * Add Cc: stable@xxxxxxxxxxxxxxx The changes here need to go below the --- line as the documentation asks. Putting it here will just break things :( v3 please? thanks, greg k-h
