On Fri, Sep 15, 2023 at 04:01:44PM +0000, Patel, Utkarsh H wrote: > > > b057250704e8..3a747938cdab 100644 > > > --- a/include/linux/usb/pd_vdo.h > > > +++ b/include/linux/usb/pd_vdo.h > > > @@ -376,6 +376,7 @@ > > > | ((vbm) & 0x3) << 9 | (sbu) << 8 | (sbut) << 7 | ((cur) & 0x3) << 5 \ > > > | (vbt) << 4 | (sopp) << 3 | ((spd) & 0x7)) > > > > > > +#define VDO_TYPEC_CABLE_SPEED(vdo) ((vdo) & 0x7) > > > > I would suggest putting this header modification in a separate patch; if for > > some reason we have to revert the Chrome part of the change, then we won't > > rip this part out too (some other driver down the road may use the macro and > > would break if it were to be removed). But I'll leave it to Heikki to determine > > whether that is preferred. > > > Heikki, What's your preference here? I think separate patch for this like Prashant said. thanks, -- heikki
