From: Abdel Alkuor <abdelalkuor@xxxxxxxxxx>
tps25750 doesn't have VID register, check VID for PD controllers
other than tps25750
Signed-off-by: Abdel Alkuor <abdelalkuor@xxxxxxxxxx>
---
drivers/usb/typec/tipd/core.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 326c23bfa8e6..c1399e12a170 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -1142,10 +1142,6 @@ static int tps6598x_probe(struct i2c_client *client)
if (IS_ERR(tps->regmap))
return PTR_ERR(tps->regmap);
- ret = tps6598x_read32(tps, TPS_REG_VID, &vid);
- if (ret < 0 || !vid)
- return -ENODEV;
-
/*
* Checking can the adapter handle SMBus protocol. If it can not, the
* driver needs to take care of block reads separately.
@@ -1176,6 +1172,12 @@ static int tps6598x_probe(struct i2c_client *client)
tps->irq_handler = irq_handler;
+ if (!tps->is_tps25750) {
+ ret = tps6598x_read32(tps, TPS_REG_VID, &vid);
+ if (ret < 0 || !vid)
+ return -ENODEV;
+ }
+
/* Make sure the controller has application firmware running */
ret = tps6598x_check_mode(tps, &mode);
if (ret)
--
2.34.1
